Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary patch #20390

Merged
merged 1 commit into from Oct 2, 2019
Merged

fix: remove unnecessary patch #20390

merged 1 commit into from Oct 2, 2019

Commits on Oct 1, 2019

  1. fix: remove unnecessary patch 

    Patch which this pr removes adds new version of
BrowserCompositorMac::GetCompositor. There is this function in
BrowserCompositorMac with specifier const. Chromium's function
returns parent's compositor if parent is set. Electron's version
doesn't and - as a result - constrained dialogs won't be displayed
correctly if they don't have its own compositor.
    @CezaryKulakowski
    CezaryKulakowski committed Oct 1, 2019
    Copy the full SHA
    2d670c4 View commit details
    Browse the repository at this point in the history