Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clipboard copy Fiddle example #20444

Closed

Conversation

RikTheunis
Copy link
Contributor

@RikTheunis RikTheunis commented Oct 6, 2019

Description of Change

Refs #20442

Adds the clipboard copy example from electron-api-demos into a runnable Fiddle example.

Gist link to Fiddle (same as code submitted in this PR): https://gist.github.com/263e01f09c1cb44da8d8bf28f2f726ce

Checklist

Release Notes

Notes: no-notes

@welcome
Copy link

welcome bot commented Oct 6, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 6, 2019
@RikTheunis RikTheunis changed the title docs: add clipboard copy fiddle example docs: add clipboard copy Fiddle example Oct 6, 2019
@codebytere
Copy link
Member

codebytere commented Oct 6, 2019

@RikTheunis Please merge this into #20445, as they're tightly coupled.

@RikTheunis
Copy link
Contributor Author

I sure can @codebytere. Should I take other sections of the electron-api-demos together as well as @erickzhao in #20442 said to open a new pull request for each demo?

@erickzhao
Copy link
Member

@RikTheunis thinking more about it, I think it'd be reasonable to make 1 PR for a set of demos that are tightly coupled as said above by @codebytere, to make it easier to give feedback and keep track of PRs.

I'll amend the original issue body to clarify.

@RikTheunis
Copy link
Contributor Author

Closing as changes are merged into #20445.

@RikTheunis RikTheunis closed this Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants