Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adds Customize Menu section Fiddle example #20468

Merged
merged 1 commit into from Oct 10, 2019

Conversation

yashints
Copy link
Contributor

@yashints yashints commented Oct 8, 2019

Description of Change

Refs #20442

Adds the Customize Menu (Create an application menu and Create a context menu) example from electron-api-demos into a runnable Fiddle example.

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 8, 2019
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just a small nit on headers

@yashints
Copy link
Contributor Author

yashints commented Oct 9, 2019

Done

@harryi3t harryi3t mentioned this pull request Oct 10, 2019
4 tasks
@jkleinsc jkleinsc merged commit 9b4ba79 into electron:master Oct 10, 2019
@welcome
Copy link

welcome bot commented Oct 10, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Oct 10, 2019

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants