Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add system get version info Fiddle example #20536

Merged
merged 1 commit into from Oct 15, 2019
Merged

docs: add system get version info Fiddle example #20536

merged 1 commit into from Oct 15, 2019

Conversation

RikTheunis
Copy link
Contributor

Description of Change

Refs #20442

Adds the system get version info example from electron-api-demos into a runnable Fiddle example.

Gist link to Fiddle (same as code submitted in this PR): https://gist.github.com/b023830ff031ab004629b2d348252e4e

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 11, 2019
felixrieseberg
felixrieseberg approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good!

@vhashimotoo vhashimotoo mentioned this pull request Oct 15, 2019
Closed
4 tasks
@codebytere codebytere merged commit 16d4ace into electron:master Oct 15, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 15, 2019

No Release Notes

@erickzhao erickzhao mentioned this pull request Oct 15, 2019
Closed
50 tasks
@RikTheunis RikTheunis deleted the hacktoberfest/system-get-version-info branch October 15, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrieseberg felixrieseberg felixrieseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RikTheunis @felixrieseberg @codebytere