fix: prevent menu gc during popup #20745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
zcbenz
approved these changes
Oct 28, 2019
jkleinsc
requested changes
Oct 28, 2019
codebytere
force-pushed
the
fix-menu-crash
branch
from
4f171a9
to
8232e64
Compare
|
@jkleinsc should be set now! |
jkleinsc
approved these changes
Oct 28, 2019
|
Release Notes Persisted
|
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
I was unable to backport this PR to "7-0-x" cleanly; |
|
I was unable to backport this PR to "6-1-x" cleanly; |
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
@codebytere has manually backported this PR to "8-x-y", please check out #20785 |
|
@codebytere has manually backported this PR to "6-1-x", please check out #20786 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #20737.
Ensures that the garbage collector will track the object stored in the handle and they won't get gc'd accidentally while they're open.
cc @MarshallOfSound @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash in Menus related to
menu.popup().