Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecation warnings in Electron code #20793

Merged
merged 1 commit into from Oct 29, 2019
Merged

fix: deprecation warnings in Electron code #20793

merged 1 commit into from Oct 29, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 28, 2019 •
edited

Description of Change

Fixes #20685

electron/lib/browser/guest-view-manager.js

Line 203 in b6246dc

zoomFactor: embedder.getZoomFactor(),

Fixes #20698

electron/lib/browser/api/browser-window.js

Line 36 in b6246dc

if (process.platform !== 'darwin' && this.isMenuBarAutoHide() && this.isMenuBarVisible()) {

Checklist

Release Notes

Notes: Fixed several deprecation warnings in Electron code.

@miniak miniak self-assigned this Oct 28, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 28, 2019
@miniak miniak force-pushed the miniak/fix-deprecation-warnings branch from a85ad55 to d9bdf2f Compare October 28, 2019 23:18
@miniak miniak changed the title fix: getZoomFactor() deprecation warning when using <webview> fix: deprecation warnings in Electron code Oct 28, 2019
@miniak miniak marked this pull request as ready for review October 28, 2019 23:35
@zcbenz zcbenz merged commit 0c87077 into master Oct 29, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 29, 2019

Release Notes Persisted

Fixed several deprecation warnings in Electron code.

@zcbenz zcbenz deleted the miniak/fix-deprecation-warnings branch October 29, 2019 04:16
@trop trop bot mentioned this pull request Oct 29, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Oct 29, 2019

I have automatically backported this PR to "7-0-x", please check out #20804

@trop trop bot removed the target/7-0-x label Oct 29, 2019
@trop trop bot mentioned this pull request Oct 29, 2019
Merged
@trop trop bot added the in-flight/7-0-x label Oct 29, 2019
@trop
Copy link
Contributor

trop bot commented Oct 29, 2019

I have automatically backported this PR to "8-x-y", please check out #20805

@sofianguy sofianguy added this to Fixed in 7.0.1 in 7.2.x Nov 4, 2019
@sofianguy sofianguy added this to Fixed in 8.0.0-beta.2 in 8.2.x Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
No open projects
7.2.x
Fixed in 7.0.1
8.2.x
Fixed in 8.0.0-beta.2
Milestone
No milestone
3 participants
@miniak @zcbenz @codebytere