chore: bump chromium to f30828899e4cd7161f6dc6507023f (master) #20824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-bot
changed the title
electron-bot
changed the title
|
cc @codebytere please take a look at the printing patch! |
chen111222333
approved these changes
Nov 2, 2019
compiles but prob doesn't work
jkleinsc
force-pushed
the
roller/chromium/master
branch
from
b9f55fa
to
6507624
Compare
nornagon
approved these changes
Nov 5, 2019
.circleci/config.yml
Outdated
| @@ -77,6 +77,9 @@ env-debug-build: &env-debug-build | |||
| GN_CONFIG: //electron/build/args/debug.gn | |||
| SKIP_DIST_ZIP: '1' | |||
|
|
|||
| env-mac-debug-build: &env-mac-debug-build | |||
| GN_EXTRA_ARGS: 'symbol_level = 0' | |||
There was a problem hiding this comment.
Add a comment about why we're setting this?
deepak1556
reviewed
Nov 5, 2019
| // Tells the RenderFrame to switch the CSS to print media type, render every | ||
| // requested page, and then switch back the CSS to display media type. | ||
| - PrintRequestedPages(); | ||
| + PrintRequestedPages(bool silent); |
There was a problem hiding this comment.
Should also patch for accepting the print setting we pass.
There was a problem hiding this comment.
yeah, this is going to be a followup. according to @codebytere it's already broken in master, so this won't break it further. #17523 is the tracking issue.
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Chromium to f30828899e4cd7161f6dc6507023f (lkgr).
See all changes in f5b345dd470f14eef6e44732ccf23..f30828899e4cd7161f6dc6507023f
Notes: no-notes