fix: do not DCHECK production-necessary methods

[codebytere]

Description of Change

InitializeContext was not being properly called in release builds due to the nature of DCHECKS.

cc @MarshallOfSound @ckerr

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue with Node.js context initialization in renderer processes.

[release-clerk]

Release Notes Persisted

Fixed an issue with Node.js context initialization in renderer processes.

[trop]

I have automatically backported this PR to "8-x-y", please check out #20836

[deepak1556]

Thanks for fixing this!

But the title and commit message are misleading, DCHECK in non debug builds noops std::ostream with operator<< which doesn't evaluate the conditions. How would having const methods change this ?

std::ostream* g_swallow_stream;

class LogMessageVoidify {
 public:
  LogMessageVoidify() = default;
  // This has to be an operator with a precedence lower than << but
  // higher than ?:
  void operator&(std::ostream& g) {  }
};

#define EAT_STREAM_PARAMETERS \
  true ? (void)0              \
       : LogMessageVoidify() & (*g_swallow_stream)
       
#define DCHECK(condition) EAT_STREAM_PARAMETERS << !(condition)

[codebytere]

oh yes sorry there's some missing context - we want to make it in a future PR so that we lint against non-const methods (methods that could have side effects on input params) being used in DCHECKs. we know it doesn't work now :)