Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable strip_absolute_paths_from_debug_symbols on debug.gn(ref #20775) #20884

Merged
merged 1 commit into from Nov 28, 2019

Conversation

ymmuse
Copy link
Contributor

@ymmuse ymmuse commented Oct 31, 2019

Description of Change

This PR is same as #20775, but it will merge into master branch. @jkleinsc

We can't set breakpoints directly in the Chromium source on XCode, Because from this commit it was set strip_absolute_paths_from_debug_symbols default to true. This PR make strip_absolute_paths_from_debug_symbols to false in debug/build.gn.

Checklist

Release Notes

Notes: Make strip_absolute_paths_from_debug_symbols to false in debug.gn

@zcbenz zcbenz merged commit 0618505 into electron:master Nov 28, 2019
@welcome
Copy link

welcome bot commented Nov 28, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Nov 28, 2019

Release Notes Persisted

Make strip_absolute_paths_from_debug_symbols to false in debug.gn

@trop
Copy link
Contributor

trop bot commented Nov 28, 2019

I have automatically backported this PR to "8-x-y", please check out #21316

@trop
Copy link
Contributor

trop bot commented Nov 28, 2019

I have automatically backported this PR to "7-1-x", please check out #21317

@nornagon
Copy link
Member

nornagon commented Dec 5, 2019

NB. the option to disable this was removed from Chromium. You'll probably need to work out how to use the gdbinit / lldbinit helper scripts from Chromium in order to debug in future.

@sofianguy sofianguy added this to Fixed in 8.0.0-beta.4 in 8.2.x Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
8.2.x
Fixed in 8.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet

4 participants