fix: stream protocols sometimes flake out #21113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Nov 18, 2019
|
CI appears to be flake, merging. |
|
Release Notes Persisted
|
This was referenced Nov 18, 2019
|
I have automatically backported this PR to "7-1-x", please check out #21179 |
|
I have automatically backported this PR to "8-x-y", please check out #21180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #21018. I'm not exactly sure why, but applying this change locally seems to resolve the problem for me.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where custom protocols registered using
registerStreamProtocolwould sometimes fail to complete the response when the stream ended.