Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow chromium to handle WM_NCCALCSIZE for frameless windows #21164

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Nov 18, 2019

Description of Change

The event wasn't handled well for frameless window because of how we claim non client view with no system frame drawn https://cs.chromium.org/chromium/src/ui/views/win/hwnd_message_handler.cc?l=1421-1423

We handle it on our end #16596 but this has led to some perf regressions when maximizing and restoring windows, however if we provide the client area insets for frameless window, chromium can handle this event very well without us having to dedupe code paths.

Refs microsoft/vscode#84343, microsoft/vscode#81102

Verified not to regress the issues previously fixed by #16596, #18321, #19883, #19886, #19928

Checklist

Release Notes

Notes: fix flickering when maximizing and restoring frameless windows

Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR under different combinations of window options and I can verify there is no regression.

The change looks good to me too.

Copy link
Contributor

@brenca brenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch!

@deepak1556 deepak1556 merged commit 73467f0 into master Nov 19, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 19, 2019

Release Notes Persisted

fix flickering when maximizing and restoring frameless windows

@trop
Copy link
Contributor

trop bot commented Nov 19, 2019

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@deepak1556
Copy link
Member Author

The failing tests are not related to this PR, merging.

@trop trop bot removed the target/6-1-x label Nov 19, 2019
@trop
Copy link
Contributor

trop bot commented Nov 19, 2019

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Nov 19, 2019

I have automatically backported this PR to "8-x-y", please check out #21201

@deepak1556 deepak1556 deleted the robo/fix_frameless_events branch November 19, 2019 14:07
@trop
Copy link
Contributor

trop bot commented Nov 19, 2019

@deepak1556 has manually backported this PR to "7-1-x", please check out #21205

@trop
Copy link
Contributor

trop bot commented Nov 19, 2019

@deepak1556 has manually backported this PR to "6-1-x", please check out #21206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.1.x
Fixed in 6.1.5
7.2.x
Fixed in 7.1.2
8.2.x
Fixed in 8.0.0-beta.3
Development

Successfully merging this pull request may close these issues.

None yet

4 participants