feat: expose executeJavaScriptInIsolatedWorld on webContents #21190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
semver/minor
zcbenz
approved these changes
Nov 19, 2019
loc
reviewed
Nov 20, 2019
docs/api/web-contents.md
Outdated
| @@ -1031,6 +1031,17 @@ contents.executeJavaScript('fetch("https://jsonplaceholder.typicode.com/users/1" | |||
| }) | |||
| ``` | |||
|
|
|||
| #### `contents.executeJavaScriptInIsolatedWorld(worldId, scripts[, userGesture])` | |||
|
|
|||
| * `worldId` Integer - The ID of the world to run the javascript in, `0` is the default world, `999` is the world used by Electrons `contextIsolation` feature. You can provide any integer here. | |||
There was a problem hiding this comment.
For my own learning: do we have any docs that guide when you'd want to use a world with an ID between 1-998?
There was a problem hiding this comment.
Not really, it's just not a world we use.
There was a problem hiding this comment.
Would probably be a little less confusing for consumers to use constants provided by Electron, I would think?
Co-Authored-By: loc <andy@slack-corp.com>
loc
approved these changes
Nov 20, 2019
|
Approved for backport to 8-x-y by the releases WG. |
miniak
approved these changes
Nov 21, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "8-x-y", please check out #21267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes
executeJavaScriptInIsolatedWorldin a similar way toexecuteJavaScriptso that folks can call it from the main process. Also cleans up the code we use for the main-process sideexecuteJavaScriptNotes: Exposed
executeJavaScriptInIsolatedWorldon thewebContentsAPI