Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add session.addWordToSpellCheckerDictionary to allow custom words in the dictionary #21266

Merged
merged 2 commits into from Nov 26, 2019
Merged

feat: add session.addWordToSpellCheckerDictionary to allow custom words in the dictionary #21266

merged 2 commits into from Nov 26, 2019

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Nov 22, 2019 •
edited by ckerr

This feature adds the missing capability of the "Add To Dictionary" context menu item for a mis-spelled word.

Notes: Added session.addWordToSpellCheckerDictionary API to support custom words in the dictionary

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 22, 2019
@MarshallOfSound MarshallOfSound added semver/minor backwards-compatible functionality target/8-x-y labels Nov 22, 2019
@nornagon
Copy link
Member

Why is this on session? Are dictionaries specific to a BrowserContext? It looks like they're not when using Chrome's spellchecker...

@MarshallOfSound
Copy link
Member Author

Are dictionaries specific to a BrowserContext? It looks like they're not when using Chrome's spellchecker...

Yes they are. https://github.com/electron/electron/pull/21266/files#diff-52cca0c5435ff413826d402cfdc8c0e4R717-R722

Each SpellcheckService is per-context. Same reason the other spell check methods are here as well

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 23, 2019
nornagon
nornagon approved these changes Nov 26, 2019
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
@MarshallOfSound MarshallOfSound merged commit 149aaeb into master Nov 26, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 26, 2019 •
edited by ckerr

Release Notes Persisted

Added session.addWordToSpellCheckerDictionary API to support custom words in the dictionary.

@MarshallOfSound MarshallOfSound deleted the add-to-dictionary branch November 26, 2019 21:16
@trop trop bot mentioned this pull request Nov 26, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Nov 26, 2019

I have automatically backported this PR to "8-x-y", please check out #21297

@sofianguy sofianguy added this to Fixed in 8.0.0-beta.7 in 8.2.x Jan 16, 2020
This was referenced Feb 5, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
No open projects
8.2.x
Fixed in 8.0.0-beta.7
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @nornagon