New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate setLayoutZoomLevelLimits #21296
Conversation
@deepak1556 do you mean this issue? #6958 |
Yup that one, users seem to have been using this api as a workaround to persist the zoom level across navigations but we later fixed it on electron core, just want to make sure its still fixed, so that we can remove this api safely. |
https://gist.github.com/8ace446c40111aca67391104c2a9cc76 I tested this in a Fiddle and it seems to work OK. However, I'm not totally sure what the original failing behavior was so I can't say for certain that I didn't accidentally dodge it somehow. Wish there had been a test written :( |
Release Notes Persisted
|
/trop run backport-to 8-x-y |
The backport process for this PR has been manually initiated - |
I have automatically backported this PR to "8-x-y", please check out #21360 |
Description of Change
This hasn't worked since Chromium removed it and I believe it's beyond our capacity to continue to support it. The function doesn't work, but instead of throwing an error it seems nicer to warn about it in 8.x and wait till 9.x to delete it completely.
Checklist
npm test
passesRelease Notes
Notes:
setLayoutZoomLevelLimits
no longer works in Electron 8, so emit a warning message when using it. The function will be removed in Electron 9.