Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load window-setup in sandboxed renderer #21416

Merged
merged 1 commit into from Jan 6, 2020

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Dec 6, 2019

Description of Change

Fixes the following issues in sandboxed renderers:

  • window.opener is null when opened with nativeWindowOpen: false
  • window.prompt() returns null instead of throwing an exception
  • document.visibilityState is broken in sandboxed <webview>

Checklist

Release Notes

Notes: Fixed an issue that could prevent communication between a sandboxed child window opened with nativeWindowOpen: false and an unsandboxed parent window. Also fixed document.visibilityState not working in sandboxed <webview>.

@miniak miniak added the wip ⚒ label Dec 6, 2019
@miniak miniak self-assigned this Dec 6, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 6, 2019
@miniak miniak force-pushed the miniak/sandbox-window-setup branch 8 times, most recently from 9044d98 to cf3541d Compare December 7, 2019 15:46
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 7, 2019
@miniak miniak marked this pull request as ready for review December 7, 2019 18:53
@miniak miniak removed the wip ⚒ label Dec 7, 2019
@trop
Copy link
Contributor

trop bot commented Dec 8, 2019

@miniak has manually backported this PR to "8-x-y", please check out #21431

@miniak miniak force-pushed the miniak/sandbox-window-setup branch from deb0cdd to e2a3084 Compare January 5, 2020 10:04
@alexeykuzmin alexeykuzmin merged commit 31c93fe into master Jan 6, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 6, 2020

Release Notes Persisted

Fixed an issue that could prevent communication between a sandboxed child window opened with nativeWindowOpen: false and an unsandboxed parent window. Also fixed document.visibilityState not working in sandboxed <webview>.

@alexeykuzmin alexeykuzmin deleted the miniak/sandbox-window-setup branch January 6, 2020 21:23
@trop
Copy link
Contributor

trop bot commented Jan 6, 2020

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jan 6, 2020

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jan 7, 2020

@miniak has manually backported this PR to "7-1-x", please check out #21696

@trop
Copy link
Contributor

trop bot commented Jan 7, 2020

@miniak has manually backported this PR to "6-1-x", please check out #21697

@sofianguy sofianguy added this to Fixed in 8.0.0-beta.6 in 8.2.x Jan 14, 2020
@sofianguy sofianguy added this to Fixed in 7.1.9 in 7.2.x Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
7.2.x
Fixed in 7.1.9
8.2.x
Fixed in 8.0.0-beta.6
Development

Successfully merging this pull request may close these issues.

None yet

7 participants