fix: window menu should handle keys correctly #21434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
Dec 9, 2019
codebytere
reviewed
Dec 9, 2019
| Date: Thu, 4 Oct 2018 14:57:02 -0700 | ||
| Subject: fix: add back virtual methods in AccessiblePaneView | ||
|
|
||
| Mark SetPaneFocus and RemovePaneFocus as virtual in AccessiblePaneView, as we |
There was a problem hiding this comment.
Can you open the CL to chromium and add that CL to this patch so that we can more easily follow/track this patch to ensure it's deleted in future?
There was a problem hiding this comment.
Submitted https://crrev.com/c/1959189.
|
Release Notes Persisted
|
This was referenced Dec 10, 2019
|
I have automatically backported this PR to "8-x-y", please check out #21452 |
|
I have automatically backported this PR to "7-1-x", please check out #21453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix a few weird behaviors and crashes when controlling window menu by keys, for example:
This was caused by Chromium removing a few virtual methods. I have added the
virtuals back, and I'll try to upstream the patch.Checklist
npm testpassesRelease Notes
Notes: Fix a weird behaviors and crashes when controlling window menu by keys.