Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hiding window menu should work on startup #21436

Merged
merged 3 commits into from Dec 9, 2019
Merged

fix: hiding window menu should work on startup #21436

merged 3 commits into from Dec 9, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Dec 9, 2019 •
edited

Description of Change

Close #21088.

This PR fixes 2 problems:

  • setDefaultApplicationMenu was called too late and it overwrote the menu set by users.
  • setMenu(null) was not working on Linux when global menubar is not used.

Checklist

Release Notes

Notes: Fix window menu unable to hide on startup.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 9, 2019
codebytere
codebytere approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MarshallOfSound MarshallOfSound merged commit 3cb0ed3 into master Dec 9, 2019
@release-clerk
Copy link

release-clerk bot commented Dec 9, 2019

Release Notes Persisted

Fix window menu unable to hide on startup.

@MarshallOfSound MarshallOfSound deleted the fix-default-menu-overwrite branch December 9, 2019 19:17
@trop
Copy link
Contributor

trop bot commented Dec 9, 2019

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Dec 9, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Dec 9, 2019

I have automatically backported this PR to "8-x-y", please check out #21443

zcbenz added a commit that referenced this pull request Dec 10, 2019
@zcbenz
fix: hiding window menu should work on startup (#21436)
d760257 
* fix: menu visibility should not be overwritten on startup

* fix: removing menu for window without global menubar

* test: setMenu tests are not for mac
@zcbenz zcbenz mentioned this pull request Dec 10, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Dec 10, 2019

@zcbenz has manually backported this PR to "7-1-x", please check out #21449

zcbenz added a commit that referenced this pull request Dec 11, 2019
@zcbenz
fix: hiding window menu should work on startup (#21436) (#21449)
38c43ab 
* fix: menu visibility should not be overwritten on startup

* fix: removing menu for window without global menubar

* test: setMenu tests are not for mac
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BrowserWindow removeMenu method not working on v7.1.1
4 participants
@zcbenz @deepak1556 @codebytere @MarshallOfSound