Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore accessibility window title on macOS #21466

Commits on Dec 10, 2019

  1. fix: restore accessibility window title on macOS

    Electron's `AtomNSWindow` implements `accessibilityAttributeValue` to
    provide various accessibility info to the OS, including window titles.
    
    Chromium 75 changed to Apple's newer accessibility API for window titles
    in the super class that `AtomNSWindow` inherits from. macOS still
    supports both the old and new style APIs, but it will prefer the new
    style if it is implemented.  This means the Electron window title is
    being ignored because the newer API at the Chromium level has taken
    precedence.
    
    By implementing the newer accessibility API in `AtomNSWindow`, this
    restores correct accessibility window titles in macOS Electron apps.
    
    This is a regression has been present since Electron 6.0.0 (the first
    release including the Chromium change above).
    jryans authored and electron-bot committed Dec 10, 2019
    Copy the full SHA
    954e99a View commit details
    Browse the repository at this point in the history