New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass full response headers in net module #21552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other kinds of filtering is Chromium doing here? Is it doing any sort of normalization that we might not want to lose? Do we only need the set-cookie
headers here?
The raw headers are populated from Currently I'm only aware the |
@nornagon Can you take another look at this? |
4f020aa
to
7bb4e08
Compare
7bb4e08
to
da40732
Compare
Release Notes Persisted
|
I have automatically backported this PR to "8-x-y", please check out #21769 |
I have automatically backported this PR to "7-1-x", please check out #21770 |
Description of Change
Close #20631.
Use raw headers instead of filtered headers in net module. This is a regression caused by network service refactoring.
Checklist
npm test
passesRelease Notes
Notes: Fix
set-cookie
header not passed in net module.