Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set enable_negotiate_port to false in allowNTLMCredentialsForDomains #21571

Merged
merged 2 commits into from Dec 19, 2019
Merged

fix: set enable_negotiate_port to false in allowNTLMCredentialsForDomains #21571

merged 2 commits into from Dec 19, 2019

Conversation

nornagon
Copy link
Member

Description of Change

Potential fix for NTLM-related bug uncovered after switching to network service. Ref #18251

Checklist

Release Notes

Notes: Fixed an issue where calling allowNTLMCredentialsForDomains() could cause a change in Kerberos SPN generation behavior.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 19, 2019
@nornagon nornagon added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases target/7-1-x labels Dec 19, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 19, 2019
@nornagon
Copy link
Member Author

/trop run backport-to 7-1-x

@trop
Copy link
Contributor

trop bot commented Dec 19, 2019

This PR has not been merged yet, and cannot be backported.

@nornagon nornagon mentioned this pull request Dec 19, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Dec 19, 2019

@nornagon has manually backported this PR to "7-1-x", please check out #21572

@MarshallOfSound MarshallOfSound merged commit 682b5d7 into master Dec 19, 2019
@release-clerk
Copy link

release-clerk bot commented Dec 19, 2019

Release Notes Persisted

Fixed an issue where calling allowNTLMCredentialsForDomains() could cause a change in Kerberos SPN generation behavior.

@MarshallOfSound MarshallOfSound deleted the fix-ntlm branch December 19, 2019 13:53
@trop trop bot mentioned this pull request Dec 19, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Dec 19, 2019

I have automatically backported this PR to "8-x-y", please check out #21580

@sofianguy sofianguy added this to Fixed in 8.0.0-beta.6 in 8.2.x Jan 14, 2020
@sofianguy sofianguy added this to Fixed in 7.1.7 in 7.2.x Jan 14, 2020
@enricojonas enricojonas mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
No open projects
7.2.x
Fixed in 7.1.7
8.2.x
Fixed in 8.0.0-beta.6
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nornagon @deepak1556 @MarshallOfSound