Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid white flash when foregrounding occluded windows #21585

Merged
merged 1 commit into from Jan 13, 2020

Conversation

loc
Copy link
Contributor

@loc loc commented Dec 19, 2019

Description of Change

Fixes #21189
Regressed in #19988

It's not super clear to me how Chrome manages this itself, as there are a bunch of layers of indirection (as usual), but this bit makes it clear that, at least some of the time, we're using the "hidden" path when we should be using the "occluded" path.

source

enum class Visibility {
  // The view is not part of any window (e.g. a non-active tab) or is part of a
  // window that is minimized or hidden (Cmd+H).
  HIDDEN,
  // The view is not visible on any screen despite not being HIDDEN. This can be
  // because it is covered by other windows and/or because it is outside the
  // bounds of the screen.
  OCCLUDED,
  // The view is visible on the screen.
  VISIBLE,
  // Note: Users may see HIDDEN/OCCLUDED views via capture (e.g. screenshots,
  // mirroring).
};

Checklist

Release Notes

Notes: Fixed white flash when foregrounding an occluded window.

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 19, 2019
@zcbenz zcbenz merged commit a0a9328 into master Jan 13, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 13, 2020

Release Notes Persisted

Fixed white flash when foregrounding an occluded window.

@trop
Copy link
Contributor

trop bot commented Jan 13, 2020

I have automatically backported this PR to "7-1-x", please check out #21750

@trop trop bot removed the target/7-1-x label Jan 13, 2020
@trop
Copy link
Contributor

trop bot commented Jan 13, 2020

I have automatically backported this PR to "8-x-y", please check out #21751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

white flash when focusing the app after occlusion (regression)
3 participants