fix: don't fallback to OpenFolderViaShell #21668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
approved these changes
Jan 3, 2020
|
@codebytere there are still two other calls to |
|
@miniak i left those initially but you may be right; all three break from Chromium technically so i'd personally be ok with removing them all. |
codebytere
force-pushed
the
dont-double-die
branch
from
afa7f4c
to
59e27a3
Compare
codebytere
force-pushed
the
dont-double-die
branch
from
59e27a3
to
2c437dd
Compare
zcbenz
approved these changes
Jan 13, 2020
|
Release Notes Persisted
|
This was referenced Jan 13, 2020
|
I have automatically backported this PR to "8-x-y", please check out #21748 |
|
I have automatically backported this PR to "7-1-x", please check out #21749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #21663.
This fallback call breaks from Chromium's approach as seen here; it was added in this commit four years ago to account for shortcomings in Chromium's approach which i feel at this point is significantly more robust. This PR thus removes the fallback so that we do not cause unexpected end-user behavior with duplicate popups and lag.
cc @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue with potential duplicate error popups when calling
shell.showItemInFolderon Windows