fix: don't unnecessarily copy draggable regions #21704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some calls to `BrowserWindow::UpdateDraggableRegions` the parameter `regions` points to object's variable `draggable_regions_` which we later try to update with data received in the parameter. In these cases coping is unnecessary. Additionally after this code is executed `draggable_regions_` would be empty and as a result whole window would be undraggable.
|
Release Notes Persisted
|
This was referenced Jan 9, 2020
|
I have automatically backported this PR to "8-x-y", please check out #21722 |
|
I have automatically backported this PR to "7-1-x", please check out #21723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some calls to
BrowserWindow::UpdateDraggableRegionsthe parameterregionspoints to object's variabledraggable_regions_which we latertry to update with data received in the parameter. In these cases coping
is unnecessary. Additionally after this code is executed
draggable_regions_would be empty and as a result whole window would be undraggable.
In our project which uses Electron it's possible to create frameless window
which doesn't repect css option
webkit-app-region: dragand is undraggablebecause of this problem but it would be hard to create one for clean
Electron.
Description of Change
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue that could cause frameless windows to become undraggable in some circumstances.