Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't unnecessarily copy draggable regions #21723

Merged
merged 1 commit into from Jan 13, 2020
Merged

fix: don't unnecessarily copy draggable regions #21723

merged 1 commit into from Jan 13, 2020

Commits on Jan 9, 2020

  1. fix: don't unnecessarily copy draggable regions 

    In some calls to `BrowserWindow::UpdateDraggableRegions` the parameter
`regions` points to object's variable `draggable_regions_` which we later
try to update with data received in the parameter. In these cases coping
is unnecessary. Additionally after this code is executed `draggable_regions_`
would be empty and as a result whole window would be undraggable.
    @CezaryKulakowski @electron-bot
    CezaryKulakowski authored and electron-bot committed Jan 9, 2020
    Copy the full SHA
    5d7e020 View commit details
    Browse the repository at this point in the history