New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: responseHeaders should be Record<string, string[]> #21730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
approved these changes
Jan 10, 2020
codebytere
approved these changes
Jan 10, 2020
MarshallOfSound
approved these changes
Jan 10, 2020
deepak1556
approved these changes
Jan 12, 2020
Release Notes Persisted
|
This was referenced Jan 12, 2020
I have automatically backported this PR to "7-1-x", please check out #21742 |
I have automatically backported this PR to "8-x-y", please check out #21743 |
ghost
pushed a commit
to wireapp/wire-desktop
that referenced
this pull request
Feb 5, 2020
An error in the typings happened a few weeks ago and the docs has been fixed accordingly electron/electron#21730
ghost
mentioned this pull request
Feb 5, 2020
ghost
pushed a commit
to wireapp/wire-desktop
that referenced
this pull request
Feb 5, 2020
An error in the typings happened a few weeks ago and the docs has been fixed accordingly electron/electron#21730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The values in
responseHeaders
are received as arrays as can be seen by running this code:outputs
Follow-up to #18302
Checklist
npm test
passesRelease Notes
Notes: Fixed
responseHeaders
types inelectron.d.ts