New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: web request support proxying websocket (#21308) #21754
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
@zimengle The code looks mostly fine to me, but for releasing a fix to 7.x, we have to first merge it to master branch and then backport it to Do you mind recreating a PR that targets the master branch instead of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unhandled exception in main spec runner: TypeError: Cannot read property '0' of undefined
at Function.<anonymous> (/home/builduser/project/src/electron/spec-main/api-session-spec.js:974:49)
not ok 840 webContents module webContents.executeJavaScript on a real page works after page load and during subframe load
TypeError: Cannot read property '0' of undefined
at Function.<anonymous> (electron/spec-main/api-session-spec.js:974:49)
is failing - additionally, we'll need you to add release notes (see failing check)
Do you guys think it's possible to have this released as a pre-release soon? |
@killpowa This PR has to be merged in master branch first, and then backported to release branches. Currently this PR targets for I can do the work if the original op @zimengle does not have time for this. |
Ok, let me know if I can donate to make this process any faster, I really need this pr merged and released as soon as possible, thanks |
I have started porting this to master branch, but it will take a while as Chromium has done large refactoring on related code. |
Closed in favor of #22040. |
Description of Change
web request of electron api can support proxying websocket
Fixes 21308
Checklist
npm test
passes