Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web request support proxying websocket (#21308) #21754

Closed
wants to merge 1 commit into from

Conversation

zimengle
Copy link

Description of Change

web request of electron api can support proxying websocket

Fixes 21308

Checklist

@welcome
Copy link

welcome bot commented Jan 13, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jan 13, 2020
@zcbenz
Copy link
Member

zcbenz commented Jan 15, 2020

@zimengle The code looks mostly fine to me, but for releasing a fix to 7.x, we have to first merge it to master branch and then backport it to 7-1-x branch.

Do you mind recreating a PR that targets the master branch instead of the 7-1-x branch?

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unhandled exception in main spec runner: TypeError: Cannot read property '0' of undefined
    at Function.<anonymous> (/home/builduser/project/src/electron/spec-main/api-session-spec.js:974:49)
not ok 840 webContents module webContents.executeJavaScript on a real page works after page load and during subframe load
  TypeError: Cannot read property '0' of undefined
      at Function.<anonymous> (electron/spec-main/api-session-spec.js:974:49)

is failing - additionally, we'll need you to add release notes (see failing check)

@blarfoon
Copy link

Do you guys think it's possible to have this released as a pre-release soon?

@zcbenz
Copy link
Member

zcbenz commented Feb 1, 2020

@killpowa This PR has to be merged in master branch first, and then backported to release branches. Currently this PR targets for 7-1-x branch and can not be merged directly.

I can do the work if the original op @zimengle does not have time for this.

@blarfoon
Copy link

blarfoon commented Feb 1, 2020

Ok, let me know if I can donate to make this process any faster, I really need this pr merged and released as soon as possible, thanks

@zcbenz
Copy link
Member

zcbenz commented Feb 3, 2020

I have started porting this to master branch, but it will take a while as Chromium has done large refactoring on related code.

@zcbenz
Copy link
Member

zcbenz commented Feb 5, 2020

Closed in favor of #22040.

@zcbenz zcbenz closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants