fix: crash when restoring minimized hidden window #21813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
fix-crash-win-min-restore
branch
from
c2bad81
to
d4823a9
Compare
codebytere
approved these changes
Jan 17, 2020
deepak1556
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Verified not to regress any previous behaviors.
@zcbenz what about 6-1-x ?
|
Release Notes Persisted
|
This was referenced Jan 17, 2020
|
I have automatically backported this PR to "7-1-x", please check out #21820 |
|
I have automatically backported this PR to "8-x-y", please check out #21821 |
|
/trop run backport-to 6-1-x |
|
The backport process for this PR has been manually initiated - |
|
I was unable to backport this PR to "6-1-x" cleanly; |
|
@codebytere has manually backported this PR to "6-1-x", please check out #22153 |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #21614.
When invoking
SetWindowPlacementinPreHandleMSGit would trigger window message proc in Chromium, and then crash under some cases because Chromium does not expect its window message proc to be called in thePreHandleMSGhook.Checklist
npm testpassesRelease Notes
Notes: Fix crash when restoring minimized hidden window on Windows.