Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call SetCanActivate in setFocusable #21846

Merged
merged 1 commit into from Jan 22, 2020
Merged

fix: call SetCanActivate in setFocusable #21846

merged 1 commit into from Jan 22, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Jan 21, 2020

Description of Change

Fix #21459.

This PR fixes the issue that calling setFocusable(true) could not turn an unfocusable window back to focusable.

Checklist

Release Notes

Notes: Fix BrowserWindow.setFocusable(true) not working on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 21, 2020
@zcbenz zcbenz merged commit 36fac7b into master Jan 22, 2020
@zcbenz zcbenz deleted the fix-win-focus branch January 22, 2020 01:13
@release-clerk
Copy link

release-clerk bot commented Jan 22, 2020

Release Notes Persisted

Fix BrowserWindow.setFocusable(true) not working on Windows.

@trop
Copy link
Contributor

trop bot commented Jan 22, 2020

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/6-1-x label Jan 22, 2020
@trop
Copy link
Contributor

trop bot commented Jan 22, 2020

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jan 22, 2020

I have automatically backported this PR to "8-x-y", please check out #21854

@trop
Copy link
Contributor

trop bot commented Jan 22, 2020

@zcbenz has manually backported this PR to "7-1-x", please check out #21855

@trop
Copy link
Contributor

trop bot commented Jan 22, 2020

@zcbenz has manually backported this PR to "6-1-x", please check out #21856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting focusable:false breaks the focus event
2 participants