Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use powerMonitor.on() only after app is ready #21927

Merged
merged 4 commits into from Jan 28, 2020
Merged

fix: use powerMonitor.on() only after app is ready #21927

merged 4 commits into from Jan 28, 2020

Commits on Jan 28, 2020

  1. fix: use powerMonitor.on() only after app is ready 

    powerMonitor can't be used until the app is ready; however, on Linux,
powerMonitor.on() was called as soon as lib/browser/api/power-monitor.ts
was loaded.

This patch takes @vladimiry's suggestion of wrapping that in an
app.on('ready') handler to prevent powerMonitor.on() from being called
prematurely.

Fixes #21716
    @ckerr
    ckerr committed Jan 28, 2020
    1 Configuration menu
    Copy the full SHA
    2f2bd8d View commit details
    Browse the repository at this point in the history

  2. refactor: handle import powerMonitor timing issue 

    Fix the previous commit's app-is-ready handler by checking to see if
app is already ready when power-monitor.ts is loaded.
    @ckerr
    ckerr committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    1c4c9e7 View commit details
    Browse the repository at this point in the history

  3. refactor: use app.whenReady() for simpler logic

    @ckerr
    ckerr committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    6798825 View commit details
    Browse the repository at this point in the history

  4. chore: use a consistent comment formatting style

    @ckerr
    ckerr committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    ff0e174 View commit details
    Browse the repository at this point in the history