Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use powerMonitor.on() only after app is ready #21941

Commits on Jan 28, 2020

  1. fix: use powerMonitor.on() only after app is ready

    powerMonitor can't be used until the app is ready; however, on Linux,
    powerMonitor.on() was called as soon as lib/browser/api/power-monitor.ts
    was loaded.
    
    This patch takes @vladimiry's suggestion of wrapping that in an
    app.on('ready') handler to prevent powerMonitor.on() from being called
    prematurely.
    
    Fixes #21716
    ckerr authored and electron-bot committed Jan 28, 2020
    Copy the full SHA
    9d343ca View commit details
    Browse the repository at this point in the history
  2. refactor: handle import powerMonitor timing issue

    Fix the previous commit's app-is-ready handler by checking to see if
    app is already ready when power-monitor.ts is loaded.
    ckerr authored and electron-bot committed Jan 28, 2020
    Copy the full SHA
    a5098f7 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    690674d View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    1944e14 View commit details
    Browse the repository at this point in the history