Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix missing docs for <webview>.print() #21962

Merged
merged 1 commit into from Jan 30, 2020
Merged

docs: fix missing docs for <webview>.print() #21962

merged 1 commit into from Jan 30, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Refs #21946.

Fixes parameters missing from <webview>.print().

cc @deepak1556

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 29, 2020
deepak1556
deepak1556 approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556
Copy link
Member

Better to add release notes for this one ?

@codebytere
Copy link
Member Author

@deepak1556 i don't think we typically add notes for docs, do we?

@deepak1556
Copy link
Member

You are right 👍

@MarshallOfSound MarshallOfSound merged commit 7c070c5 into master Jan 30, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 30, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the fix-docs-webview-print branch January 30, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @deepak1556 @MarshallOfSound