Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for app.on('certificate-error') event #21978

Merged
merged 3 commits into from Jan 31, 2020
Merged

test: add test for app.on('certificate-error') event #21978

merged 3 commits into from Jan 31, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jan 30, 2020 •
edited

Description of Change

Adds a test for #21976.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 30, 2020
@nornagon nornagon changed the title spec: add test for app.on('certificate-error') event test add test for app.on('certificate-error') event Jan 30, 2020
@nornagon nornagon changed the title test add test for app.on('certificate-error') event test: add test for app.on('certificate-error') event Jan 30, 2020
@nornagon nornagon changed the title test: add test for app.on('certificate-error') event test: add test for app.on('certificate-error') event Jan 30, 2020
@nornagon nornagon changed the title test: add test for app.on('certificate-error') event test: add test for app.on('certificate-error') event Jan 30, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 30, 2020
@nornagon nornagon merged commit 720cf6e into master Jan 31, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2020

No Release Notes

@nornagon nornagon deleted the certificate-error-test branch January 31, 2020 23:25
@nornagon
Copy link
Member Author

/trop run backport-to 8-x-y

@trop
Copy link
Contributor

trop bot commented Feb 10, 2020

The backport process for this PR has been manually initiated -
sending your commits to "8-x-y"!

@nornagon
Copy link
Member Author

/trop run backport-to 9-x-y

@trop
Copy link
Contributor

trop bot commented Feb 10, 2020

The backport process for this PR has been manually initiated -
sending your commits to "9-x-y"!

@trop
Copy link
Contributor

trop bot commented Feb 10, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Feb 10, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

nornagon added a commit that referenced this pull request Feb 10, 2020
@nornagon
test: add test for app.on('certificate-error') event (#21978)
721c97e
@nornagon nornagon mentioned this pull request Feb 10, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Feb 10, 2020

@nornagon has manually backported this PR to "8-x-y", please check out #22124

codebytere pushed a commit that referenced this pull request Feb 11, 2020
@nornagon
fix: don't crash on invalid certs (#22124)
637cf8a 
* test: add test for app.on('certificate-error') event (#21978)

* types

* fix: don't crash on invalid certs (#21976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @MarshallOfSound