New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return path from netLog.stopLogging #21985
Conversation
this._currentlyLoggingPath = null | ||
return _originalStopLogging.call(this) | ||
return _originalStopLogging.call(this).then(() => logPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So simple
Throwing on [fast-track] to try to get this in before the 8.0.0 stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Release Notes Persisted
|
I have automatically backported this PR to "7-1-x", please check out #21988 |
I have automatically backported this PR to "8-x-y", please check out #21989 |
Description of Change
The docs say we return a string, so let's do that. This was broken by the refactor in #18289.
It's a bit weird that we save the path on behalf of the user—all we're doing is keeping track of the value they passed in. That should really be the responsibility of the user, not the API, but since that's how it's documented to work, we might as well make it work the way the docs say (and the way it used to work).
Checklist
npm test
passesRelease Notes
Notes: Fixed netLog.stopLogging returning undefined instead of the path to the log.