Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: default to sys printer and prevent bad default crash #22012

Merged
merged 2 commits into from Feb 12, 2020
Merged

chore: default to sys printer and prevent bad default crash #22012

merged 2 commits into from Feb 12, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 3, 2020 •
edited

Backport of #21946.
Backport of #21956

Notes: Fixed a potential crash on faulty deviceNames in webContents.print().

@codebytere
fix: prevent print crash on bad deviceName (#21946)
0b00ff6 
* fix: prevent print crash on bad deviceName

* address review feedback
@codebytere codebytere requested review from jkleinsc and a team February 3, 2020 16:52
@codebytere codebytere requested a review from a team as a code owner February 3, 2020 16:52
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 3, 2020
@trop trop bot mentioned this pull request Feb 3, 2020
Merged
6 tasks
@trop trop bot added 7-1-x backport This is a backport PR labels Feb 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 3, 2020
@codebytere codebytere changed the title Default to default 7 chore: default to system printer and prevent bad default crash Feb 3, 2020
@codebytere codebytere changed the title chore: default to system printer and prevent bad default crash chore: default to sys printer and prevent bad default crash Feb 3, 2020
@codebytere
Copy link
Member Author

I'll get this fixed up soon

@codebytere codebytere force-pushed the default-to-default-7 branch 2 times, most recently from b3954b8 to 8c537b3 Compare February 11, 2020 17:45
@codebytere
Copy link
Member Author

@jkleinsc finally got this fixed & ready to go 🚀

jkleinsc
jkleinsc approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere codebytere merged commit f0d8729 into 7-1-x Feb 12, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 12, 2020

Release Notes Persisted

Fixed a potential crash on faulty deviceNames in webContents.print().

@codebytere codebytere deleted the default-to-default-7 branch February 12, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc