chore: wrap cb with default invocation #22013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
default-invoke
branch
from
66073ce
to
e0f8a42
Compare
deepak1556
approved these changes
Feb 3, 2020
MarshallOfSound
approved these changes
Feb 3, 2020
nornagon
approved these changes
Feb 3, 2020
|
Failures are Chromedriver and mksnapshot and thus unrelated to this PR; merging. |
|
No Release Notes |
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
@codebytere has manually backported this PR to "8-x-y", please check out #22036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In Chrome's own print preview message handling, they wrap their pdf composition callback in a Mojo default invoker, which is designed to be run on cases where the connection is dropped or similar. This ensures that the callback is not dropped on the floor and is run so the function chain can complete. We should do the same.
cc @deepak1556 @nornagon
Checklist
npm testpassesRelease Notes
Notes: none