Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flash plugin #22072

Merged
merged 3 commits into from Feb 9, 2020
Merged

fix: flash plugin #22072

merged 3 commits into from Feb 9, 2020

Conversation

t57ser
Copy link
Contributor

@t57ser t57ser commented Feb 6, 2020

Description of Change

Close #20744

Checklist

Release Notes

Notes: Fix flash plugin not working

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 6, 2020
@t57ser t57ser mentioned this pull request Feb 6, 2020
Closed
3 tasks
@t57ser
Copy link
Contributor Author

t57ser commented Feb 6, 2020

Note: This should also be backported to version 8 and 7

@andreieftimie
Copy link

Awesome!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 7, 2020
@fp07
Copy link

fp07 commented Feb 7, 2020

Review status?

deepak1556
deepak1556 requested changes Feb 8, 2020
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! LGTM with minor cleanup.

shell/browser/net/system_network_context_manager.cc Outdated Show resolved Hide resolved
@deepak1556 deepak1556 merged commit 43592f8 into electron:master Feb 9, 2020
@welcome
Copy link

welcome bot commented Feb 9, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Feb 9, 2020

Release Notes Persisted

Fix flash plugin not working

@trop trop bot mentioned this pull request Feb 9, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Feb 9, 2020

I have automatically backported this PR to "7-1-x", please check out #22109

@trop trop bot mentioned this pull request Feb 9, 2020
Merged
@trop trop bot mentioned this pull request Feb 9, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Feb 9, 2020

I have automatically backported this PR to "8-x-y", please check out #22110

@trop
Copy link
Contributor

trop bot commented Feb 9, 2020

I have automatically backported this PR to "9-x-y", please check out #22111

@t57ser t57ser deleted the patch-1 branch February 10, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flash SWF content not correctly loaded in Electron 7
5 participants
@t57ser @andreieftimie @fp07 @deepak1556 @jkleinsc