Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add session.listWordsInSpellCheckerDictionary API #22128

Merged
merged 3 commits into from Feb 14, 2020
Merged

feat: add session.listWordsInSpellCheckerDictionary API #22128

merged 3 commits into from Feb 14, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 10, 2020 •
edited by jkleinsc

Backport of #22101

See that PR for details.

Notes: Added session.listWordsInSpellCheckerDictionary API to list custom words in the dictionary.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2020
@trop trop bot mentioned this pull request Feb 10, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Feb 10, 2020
codebytere
codebytere requested changes Feb 11, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending vote.

@codebytere codebytere added backport/requested 🗳 and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 11, 2020
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 11, 2020
@jkleinsc
Copy link
Contributor

The releases WG voted to approve this for 9-x-y.

@jkleinsc jkleinsc merged commit 57ec30e into 9-x-y Feb 14, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 14, 2020

Release Notes Persisted

Added session.listWordsFromSpellCheckerDictionary API to list custom words in the dictionary.

@jkleinsc jkleinsc deleted the trop/9-x-y-bp-feat-add-session-listwordsfromspellcheckerdictionary-api-1581372545432 branch February 14, 2020 20:26
@ahallicks
Copy link

Just to note on this (as it just caught me out) the method is listWordsInSpellCheckerDictionary not listWordsFromSpellCheckerDictionary as it says in the release notes!

@jkleinsc jkleinsc changed the title feat: add session.listWordsFromSpellCheckerDictionary API feat: add session.listWordsInSpellCheckerDictionary API May 20, 2020
@jkleinsc
Copy link
Contributor

@ahallicks thanks for catching that! I updated the release notes with the correct method name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkleinsc @ahallicks @codebytere @erickzhao