fix: bug when repositioning traffic lights in RTL mode #22132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Feb 11, 2020
codebytere
approved these changes
Feb 11, 2020
zcbenz
approved these changes
Feb 12, 2020
|
Release Notes Persisted
|
This was referenced Feb 12, 2020
|
I have automatically backported this PR to "8-x-y", please check out #22162 |
|
I have automatically backported this PR to "9-x-y", please check out #22163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow-up to #21781 and #22016, there is a bug when using the new
trafficLightPositionAPI when the system is in RTL mode. cc @mohitsud @seshrsUsing
trafficLightPosition: {x: 1, y: 1}:Bug:
Fixed:
Bug is due to the fact that the x-position is always calculated from the top left of the screen when using
trafficLightPosition, but in RTL mode we should calculate the offset from the right.Checklist
npm testpassesRelease Notes
Notes: Fixed bug that occurred when using trafficLightPosition API in RTL mode