fix: make webRequest work with WebSocket #22133

trop · 2020-02-11T05:56:31Z

Backport of #22040

See that PR for details.

Notes: Fix webRequest API not working with WebSockets.

release-clerk · 2020-02-11T20:56:05Z

Release Notes Persisted

Fix webRequest API not working with WebSockets.

zhangzimeng01 and others added 6 commits February 11, 2020 05:56

fix: web request support proxying websocket

d862643

fix: make tests work

ecf2606

chore: do not use api:: code outside api/ folder

fb20f77

chore: do not create proxy when no listener

627db25

test: use separate session to avoid conflicts

43adf7d

chore: address review

bee7c73

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2020

trop bot requested a review from zcbenz February 11, 2020 05:56

trop bot mentioned this pull request Feb 11, 2020

fix: make webRequest work with WebSocket #22040

Merged

5 tasks

trop bot added 9-x-y backport This is a backport PR labels Feb 11, 2020

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2020

codebytere approved these changes Feb 11, 2020

View reviewed changes

jkleinsc approved these changes Feb 11, 2020

View reviewed changes

jkleinsc merged commit f414235 into 9-x-y Feb 11, 2020

jkleinsc deleted the trop/9-x-y-bp-fix-make-webrequest-work-with-websocket-1581400583285 branch February 11, 2020 20:56

Provide feedback