Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no-arg console.log is undefined #22165

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 12, 2020

Description of Change

Closes #22108.

@types/node incorrectly types the signature for util.format(); it should in fact per documentation be:

function format(format?: any, ...param: any[]): string;

This corrects the error and fixed the undefined behavior. I'll also try to open a PR to the upstream @types/node repo.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Fixes an issue where undefined was printed from console.log on Window when no arguments were passed.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 12, 2020
@MarshallOfSound MarshallOfSound merged commit 5e7c594 into master Feb 12, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 12, 2020

Release Notes Persisted

Fixes an issue where undefined was printed from console.log on Window when no arguments were passed.

@trop
Copy link
Contributor

trop bot commented Feb 12, 2020

I have automatically backported this PR to "9-x-y", please check out #22171

@trop trop bot removed the target/9-x-y label Feb 12, 2020
@trop
Copy link
Contributor

trop bot commented Feb 12, 2020

I have automatically backported this PR to "8-x-y", please check out #22172

@trop trop bot added the in-flight/9-x-y label Feb 12, 2020
@trop
Copy link
Contributor

trop bot commented Feb 12, 2020

I have automatically backported this PR to "7-1-x", please check out #22173

@ckerr
Copy link
Member

ckerr commented Feb 12, 2020

@MarshallOfSound I'm 👍 on merging this but am confused why it was done while still a new-pr w/o a fast track?

@codebytere codebytere deleted the fix-console-log-win branch February 12, 2020 17:29
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 14, 2020
@trop trop bot added the merged/7-1-x label Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling console.log on windows with no arguments causes 'undefined' in stdout
4 participants