Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: programmatically modify traffic light positioning #22533

Merged
merged 5 commits into from
Mar 5, 2020
Merged

feat: programmatically modify traffic light positioning #22533

merged 5 commits into from
Mar 5, 2020

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Mar 4, 2020 •
edited

Description of Change

PR #21781 added custom traffic light positioning for Browser Window title bars on macOS. This PR extends the existing functionality by allowing developers to set this property on the fly with a pair of APIs.

// setter
void win.setTrafficLightPosition(Point position)
// getter
Point win.getTrafficLightPosition()

Checklist

Release Notes

Notes: Added ability to set and get title bar traffic light position on the fly (macOS).

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 4, 2020
@erickzhao erickzhao changed the title [WIP] feat: programmatically modify traffic light positioning feat: programmatically modify traffic light positioning Mar 5, 2020
@erickzhao erickzhao removed the wip ⚒ label Mar 5, 2020
MarshallOfSound
MarshallOfSound approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@MarshallOfSound MarshallOfSound merged commit 3e2cec8 into electron:master Mar 5, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 5, 2020

Release Notes Persisted

Added ability to set and get title bar traffic light position on the fly (macOS).

@trop
Copy link
Contributor

trop bot commented Mar 5, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/8-x-y label Mar 5, 2020
@trop
Copy link
Contributor

trop bot commented Mar 5, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

MarshallOfSound added a commit that referenced this pull request Mar 5, 2020
@MarshallOfSound
feat: programmatically modify traffic light positioning (#22533)
9f8c2fa 
* setter

* getter

* specs and docs

* fixup

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@MarshallOfSound MarshallOfSound mentioned this pull request Mar 5, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Mar 5, 2020

@MarshallOfSound has manually backported this PR to "8-x-y", please check out #22564

MarshallOfSound added a commit that referenced this pull request Mar 5, 2020
@MarshallOfSound
feat: programmatically modify traffic light positioning (#22533)
a5a0b5b 
* setter

* getter

* specs and docs

* fixup

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
MarshallOfSound added a commit that referenced this pull request Mar 5, 2020
@MarshallOfSound
feat: programmatically modify traffic light positioning (#22533)
2d2d036 
* setter

* getter

* specs and docs

* fixup

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@erickzhao erickzhao deleted the feat/traffic-lights-on-the-fly branch March 5, 2020 23:03
erickzhao pushed a commit to erickzhao/ericktron that referenced this pull request Mar 5, 2020
@MarshallOfSound @erickzhao
feat: programmatically modify traffic light positioning (electron#22533)
f7aca8c 
* setter

* getter

* specs and docs

* fixup

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@erickzhao erickzhao mentioned this pull request Mar 5, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Mar 5, 2020

@erickzhao has manually backported this PR to "9-x-y", please check out #22566

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 5, 2020
MarshallOfSound added a commit that referenced this pull request Mar 6, 2020
@MarshallOfSound
feat: programmatically modify traffic light positioning (#22533) (#22566
539ca77 
)

* setter

* getter

* specs and docs

* fixup

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@trop trop bot added the merged/9-x-y label Mar 6, 2020
@jkleinsc
Copy link
Contributor

jkleinsc commented Mar 6, 2020

The Releases WG has approved this for backporting to 8-x-y and 9-x-y.

@trop trop bot removed the in-flight/8-x-y label Mar 6, 2020
MarshallOfSound added a commit that referenced this pull request Mar 6, 2020
@MarshallOfSound
feat: programmatically modify traffic light positioning (#22533) (#22564
b4e1b84 
)

* setter

* getter

* specs and docs

* fixup

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@trop trop bot added the merged/8-x-y label Mar 6, 2020
@sofianguy sofianguy added this to Fixed in 8.1.0 in 8.2.x Mar 6, 2020
@sofianguy sofianguy added this to Fixed in 9.0.0-beta.7 in 9-x-y Apr 3, 2020
@say25 say25 mentioned this pull request Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
8.2.x
Fixed in 8.1.0
9-x-y
Fixed in 9.0.0-beta.7
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erickzhao @jkleinsc @MarshallOfSound