build: fix broken Views build #22621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Mar 10, 2020
codebytere
changed the title
codebytere
force-pushed
the
fix-views-build
branch
from
554c349
to
cd2417b
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "9-x-y", please check out #22642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I went to test something with the Views APIs and discovered that they extremely did not build. Now they do. I turned off the flag to demonstrate such but will turn it back off before merging this PR.
cc @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Fixed broken Views API builds.