Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround for hang when preventDefault-ing nativeWindowOpen #22749

Merged
merged 5 commits into from Mar 25, 2020
Merged

fix: workaround for hang when preventDefault-ing nativeWindowOpen #22749

merged 5 commits into from Mar 25, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 18, 2020

Backport of #21497

See that PR for details.

Notes: Added workaround for nativeWindowOpen hang.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 18, 2020
@trop trop bot requested a review from loc March 18, 2020 18:38
@trop trop bot mentioned this pull request Mar 18, 2020
Merged
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Mar 18, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 18, 2020
@loc loc changed the title fix: workaround for hang when preventDefault-ing nativeWindowOpen (7-1-x) fix: workaround for hang when preventDefault-ing nativeWindowOpen Mar 18, 2020
@loc loc force-pushed the trop/8-x-y-bp-fix-workaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556681501 branch from 7bce9eb to 56d91f8 Compare March 19, 2020 01:18
@loc loc force-pushed the trop/8-x-y-bp-fix-workaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556681501 branch from 56d91f8 to f1b212c Compare March 19, 2020 02:08
@loc
Merge remote-tracking branch 'origin/8-x-y' into trop/8-x-y-bp-fix-wo…
f8bb0c1 
…rkaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556681501
@zcbenz zcbenz merged commit 8751f48 into 8-x-y Mar 25, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 25, 2020

Release Notes Persisted

Added workaround for nativeWindowOpen hang.

@zcbenz zcbenz deleted the trop/8-x-y-bp-fix-workaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556681501 branch March 25, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@loc loc Awaiting requested review from loc

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @loc