Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround for hang when preventDefault-ing nativeWindowOpen #22750

Merged
merged 5 commits into from Mar 25, 2020
Merged

fix: workaround for hang when preventDefault-ing nativeWindowOpen #22750

merged 5 commits into from Mar 25, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 18, 2020

Backport of #21497

See that PR for details.

Notes: Added workaround for nativeWindowOpen hang.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 18, 2020
@trop trop bot requested a review from loc March 18, 2020 18:38
@trop trop bot mentioned this pull request Mar 18, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Mar 18, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 18, 2020
@loc loc changed the title fix: workaround for hang when preventDefault-ing nativeWindowOpen (7-1-x) fix: workaround for hang when preventDefault-ing nativeWindowOpen Mar 18, 2020
zcbenz
zcbenz requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing.

@loc
Merge remote-tracking branch 'origin/9-x-y' into trop/9-x-y-bp-fix-wo…
f24780c 
…rkaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556691390
@loc
Copy link
Contributor

loc commented Mar 24, 2020

@zcbenz okay, I believe this is good to go.

@loc loc requested a review from zcbenz March 24, 2020 22:39
@zcbenz zcbenz merged commit a6ff42c into 9-x-y Mar 25, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 25, 2020

Release Notes Persisted

Added workaround for nativeWindowOpen hang.

@zcbenz zcbenz deleted the trop/9-x-y-bp-fix-workaround-for-hang-when-preventdefault-ing-nativewindowopen-7-1-x--1584556691390 branch March 25, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@loc loc Awaiting requested review from loc

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loc @nornagon @zcbenz