Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow window to go behind menu bar on mac #22770

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

CezaryKulakowski
Copy link
Contributor

This change fixes #22667.

Notes: don't allow window to go behind menu bar on mac

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 19, 2020
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@zcbenz
Copy link
Member

zcbenz commented Mar 24, 2020

Do you mind rebasing this PR on master? We now require semicolon in JS files.

@CezaryKulakowski
Copy link
Contributor Author

@zcbenz I've made a rebase to the newest master. I've also squashed two commits into one.

@zcbenz zcbenz merged commit bdef77b into electron:master Mar 25, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 25, 2020

Release Notes Persisted

don't allow window to go behind menu bar on mac

@trop
Copy link
Contributor

trop bot commented Mar 25, 2020

I have automatically backported this PR to "9-x-y", please check out #22828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app window can be placed behind menu bar on mac
3 participants