fix: dialog fails to show after modal close #22858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-dialog-no-show
branch
from
ddc7564
to
e6aab95
Compare
zcbenz
reviewed
Mar 27, 2020
|
I don't see any macOS error noise though, probably related to macOS version or SDK version. |
codebytere
force-pushed
the
fix-dialog-no-show
branch
from
e6aab95
to
8d89a03
Compare
codebytere
force-pushed
the
fix-dialog-no-show
branch
from
8d89a03
to
e4deb56
Compare
zcbenz
approved these changes
Mar 28, 2020
|
Release Notes Persisted
|
This was referenced Mar 30, 2020
|
I have automatically backported this PR to "8-x-y", please check out #22889 |
|
I have automatically backported this PR to "9-x-y", please check out #22890 |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #22833.
The solution to #17558 unfortunately created a new issue, whereby native dialogs sometimes failed to open after modal close.
This PR fixes this by shifting the modal handling case logic to our delegate as Chromium does.
Tested with:
cc @zcbenz @nornagon @kenpowers-signal
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where native macOS dialogs sometimes failed to show after modal close.