Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect system language preferences on Windows & macOS #23247

Merged
merged 1 commit into from
May 4, 2020

Commits on Apr 28, 2020

  1. feat: respect language preferences on Win/macOS

    This commit fixes electron#18829
    
    Previously the full preferences set to OS was not given to Chromium.
    
    Also, this commit improves fallback font selection for CJK text.
    Chromium uses browser languages to determine fallback fonts on Windows,
    especially kanji/han characters in CJK.
    
    For instance, when user sets 'en-US, ja-JP' to Accept-Language,
    while Chromium chooses Japanese font for kanji text, but Electron
    chooses Chinese font.  This is because only the first language was given
    to Accept-Language on Electron.
    
    This patch is based on electron#15532
    
    Co-authored-by: Nitish Sakhawalkar <nitsakh@icloud.com>
    Co-authored-by: Kasumi Hanazuki <kasumi@rollingapple.net>
    3 people committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    dfbfb3d View commit details
    Browse the repository at this point in the history