build: remove unused header from a patch #23585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
May 14, 2020
miniak
approved these changes
May 14, 2020
It can cause build failures because the header is generated and there's no explicit dependency on a target that creates it.
alexeykuzmin
force-pushed
the
alkuzmin/fix-build-on-macos
branch
from
d0e8f7d
to
356ae3e
Compare
nornagon
approved these changes
May 14, 2020
|
No Release Notes |
This was referenced May 14, 2020
|
I have automatically backported this PR to "9-x-y", please check out #23590 |
|
I have automatically backported this PR to "8-x-y", please check out #23591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
It can cause build failures because the header is generated
and there's no explicit dependency on a target that creates it.
Related to #21959.
Checklist
npm testpassesRelease Notes
Notes: none