Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nativeImage remote serialization #24021

Merged
merged 1 commit into from Jun 11, 2020

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Jun 8, 2020

Description of Change

Manually backport #23543 to 7-3-x.
Manually backport #23666 to 7-3-x.
Manually backport #23693 to 7-3-x.
Manually backport #23759 to 7-3-x.

See those PRs for more details.

This PR is mostly a backport of #23797 with the following changes for compatibility to 7-3-x:

  • add dirty-chai devdep to spec-main
  • remove serialization tests for RegExp, Date, and Error because 7-3-x predates the SCA refactor

CC @codebytere @electron/wg-releases

Checklist

Release Notes

Notes: Ensured proper nativeImage serialization between renderer and browser processes via remote.

@ckerr ckerr requested a review from a team June 8, 2020 21:28
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 8, 2020
@trop trop bot mentioned this pull request Jun 8, 2020
4 tasks
@trop trop bot added 7-3-x backport This is a backport PR labels Jun 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 8, 2020
@ckerr ckerr requested a review from codebytere June 10, 2020 13:47
@jkleinsc
Copy link
Contributor

Merging as CI failures unrelated to PR change.

@jkleinsc jkleinsc merged commit 4fb7b33 into 7-3-x Jun 11, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 11, 2020

Release Notes Persisted

Ensured proper nativeImage serialization between renderer and browser processes via remote.

@jkleinsc jkleinsc deleted the backport/7-3-x/23543-fix-nativeimage-serialization branch June 11, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-3-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants