fix: Revert "fix: do not use CONTEXT_MENU flag for tray menu" #24076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b809d10.
MarshallOfSound
changed the title
codebytere
approved these changes
Jun 11, 2020
|
I don't love this, since it means we're re-breaking a11y. This change is a tradeoff between an important bug for a small set of a11y users vs a visual annoyance for a larger set of users. Since tray a11y on Windows has been broken for several versions, it's understandable as an interim move -- but we still need to find a better fix for #11587. |
|
No Release Notes |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Jul 30, 2020
…)" (electron#24076) This reverts commit b809d10.
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 8, 2021
…)" (electron#24076) This reverts commit b809d10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23843
As per #24049
Notes: no-notes